Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drain Safe] Warn for those tokens with really low amount or USD value #164

Closed
2 tasks
dasanra opened this issue Oct 18, 2021 · 0 comments · Fixed by #236
Closed
2 tasks

[Drain Safe] Warn for those tokens with really low amount or USD value #164

dasanra opened this issue Oct 18, 2021 · 0 comments · Fixed by #236
Assignees
Labels
Enhancement ✨ Design or functionality improvement

Comments

@dasanra
Copy link
Collaborator

dasanra commented Oct 18, 2021

Overview

Currently the user can select which tokens to be transferred when draining a Safe. But many safes suffer of spam tokens or may have tokens with low amounts which are not interesting to transfer, because the transfer cost would be higher than the token value.

Goals

We should give the user some feedback to detect this tokens that may not be worth to transfer because the cost would be higher than the cost of moving them.

  • We should compare for each token when the fiat value can overpass the transaction cost of transferring it
  • Show a yellow warning sign ⚠️ or something similar next to the fiat value of the token.

Requirements

How to check that transfer value is higher than the fiat value?

  • We can have an approximation of how much calling an ERC20 send will cost in terms of gas. This will be a fixed amount.
  • We should fetch the gwei fast price for the chain at that moment so we can say if it could be more costly than current value
  • We should fetch the fiat value of the token used to pay the transaction so we can compare the amount to the cost
@dasanra dasanra added the Enhancement ✨ Design or functionality improvement label Oct 18, 2021
@dasanra dasanra changed the title [Drain Safe] Include a USD value threshold [Drain Safe] Warn for those tokens with really low amount or USD value Oct 19, 2021
@mmv08 mmv08 added this to Product backlog in Safe Apps Nov 3, 2021
@dasanra dasanra added question Further information is requested and removed question Further information is requested labels Nov 18, 2021
@dasanra dasanra moved this from Product backlog to Current sprint in Safe Apps Nov 30, 2021
@DaniSomoza DaniSomoza moved this from Current sprint to Development in progress in Safe Apps Dec 1, 2021
@DaniSomoza DaniSomoza self-assigned this Dec 1, 2021
@DaniSomoza DaniSomoza moved this from Development in progress to Code review and dev test in Safe Apps Dec 9, 2021
@DaniSomoza DaniSomoza moved this from Code review and dev test to Ready for QA in Safe Apps Dec 13, 2021
@JagoFigueroa JagoFigueroa moved this from Ready for QA to QA in progress in Safe Apps Dec 13, 2021
@JagoFigueroa JagoFigueroa moved this from QA in progress to QA done in Safe Apps Dec 14, 2021
Safe Apps automation moved this from QA done to Closed Dec 14, 2021
@dasanra dasanra mentioned this issue Jan 13, 2022
@rmeissner rmeissner removed this from Closed in Safe Apps May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Design or functionality improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants