Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX-Builder] Allow custom contract data #214

Closed
2 tasks
dasanra opened this issue Nov 25, 2021 · 1 comment · Fixed by #231
Closed
2 tasks

[TX-Builder] Allow custom contract data #214

dasanra opened this issue Nov 25, 2021 · 1 comment · Fixed by #231
Assignees
Labels
Enhancement ✨ Design or functionality improvement

Comments

@dasanra
Copy link
Collaborator

dasanra commented Nov 25, 2021

Overview

Currently in the Transaction Builder we only allow to create new transactions by selecting and filling the complete information after an ABI is provided and all fields are filled. Some users could prepare some custom data in some other dapp and just be willing to send it from the TX-Builder, for example sending a transaction where the signatures were gathered off chain

Goals

We should allow switching to show custom hex encoded data the same way we allow it in contract interaction, either converting the user input to hex data or allowing to send custom hex data

Requirements

  • Allow input custom hex data to add a new transaction to the transaction builder
  • Show custom hex data when user filled the different inputs when interacting with a smart contract

Screens

Example in "Contract interaction" used as TX-Builder
image

Example in "Contract interaction" of custom hex data transaction
imagen

Any doubts we should check contract interaction feature on Safe web

@dasanra dasanra added this to New Issues in Safe Apps via automation Nov 25, 2021
@dasanra dasanra added the Enhancement ✨ Design or functionality improvement label Nov 25, 2021
@dasanra dasanra moved this from New Issues to Product backlog in Safe Apps Nov 25, 2021
@dasanra dasanra moved this from Product backlog to Current sprint in Safe Apps Nov 30, 2021
@yagopv yagopv moved this from Current sprint to Development in progress in Safe Apps Nov 30, 2021
@yagopv yagopv self-assigned this Nov 30, 2021
@yagopv yagopv moved this from Development in progress to Code review and dev test in Safe Apps Dec 9, 2021
@yagopv yagopv moved this from Code review and dev test to Ready for QA in Safe Apps Dec 10, 2021
@JagoFigueroa JagoFigueroa moved this from Ready for QA to QA in progress in Safe Apps Dec 13, 2021
@JagoFigueroa
Copy link
Contributor

Hi there! Just to clarify @dasanra custom data is always expected to come with an {{asset}} value field regardless of the method used right?

@yagopv made it so that instead of a required field it is now optional but it is different to the current implementation on web (which I really like but I mention this in case needs to be exactly the same. When no value is input, it will be understood as a 0 instead of being a required 0.

Current implementation when performing a contract interaction on web:

Screenshot 2021-12-13 at 11 03 25

Yagos approach on tx builder:

Screenshot 2021-12-13 at 11 03 48

@JagoFigueroa JagoFigueroa moved this from QA in progress to QA done in Safe Apps Dec 14, 2021
Safe Apps automation moved this from QA done to Closed Dec 14, 2021
@dasanra dasanra mentioned this issue Jan 13, 2022
@rmeissner rmeissner removed this from Closed in Safe Apps May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Design or functionality improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants