Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compound] Improve Compound markets detection #223

Closed
2 tasks
dasanra opened this issue Dec 1, 2021 · 1 comment · Fixed by #266
Closed
2 tasks

[Compound] Improve Compound markets detection #223

dasanra opened this issue Dec 1, 2021 · 1 comment · Fixed by #266
Assignees
Labels
Enhancement ✨ Design or functionality improvement

Comments

@dasanra
Copy link
Collaborator

dasanra commented Dec 1, 2021

Overview

Currently we are showing some outdated or deprecated markets in Compound safe app. Also we are not showing new markets with better yield. We should update the markets to allow users to interact with new markets and get better yields.

Goals

  • Automatically detect compound markets for example using their graph
  • Avoid market duplication, deprecated markets should not be shown. Deprecated markets can be check here

Requirements

  • At the end of this ticket the market list should be up to date
  • Currently there is a fixed token list. This should be like this still for Rinkeby or we would break app compatibility with test chain
@dasanra dasanra added the Enhancement ✨ Design or functionality improvement label Dec 1, 2021
@dasanra dasanra added this to New Issues in Safe Apps via automation Dec 1, 2021
@dasanra dasanra moved this from New Issues to Product backlog in Safe Apps Dec 1, 2021
@yagopv
Copy link
Member

yagopv commented Jan 7, 2022

We could use https://api.compound.finance/api/v2/ctoken but only works on mainnet. We can make a manual config fallback for Rinkeby

@yagopv yagopv moved this from Product backlog to Development in progress in Safe Apps Jan 10, 2022
@yagopv yagopv self-assigned this Jan 10, 2022
@yagopv yagopv moved this from Development in progress to Code review and dev test in Safe Apps Jan 11, 2022
@yagopv yagopv moved this from Code review and dev test to Ready for QA in Safe Apps Jan 11, 2022
@JagoFigueroa JagoFigueroa moved this from Ready for QA to QA in progress in Safe Apps Jan 11, 2022
Safe Apps automation moved this from QA in progress to Closed Jan 12, 2022
@dasanra dasanra mentioned this issue Jan 13, 2022
@rmeissner rmeissner removed this from Closed in Safe Apps May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Design or functionality improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants