Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tx Builder] Align styling for all available fields #228

Closed
JagoFigueroa opened this issue Dec 2, 2021 · 0 comments · Fixed by #256
Closed

[Tx Builder] Align styling for all available fields #228

JagoFigueroa opened this issue Dec 2, 2021 · 0 comments · Fixed by #256
Assignees
@yagopv
Labels
Enhancement ✨ Design or functionality improvement

Comments

@JagoFigueroa
Copy link
Contributor

Description

Currently we are using at least 3 different implementations when it comes to validations / error handling for this app:

Screenshot 2021-12-02 at 15 09 07
Screenshot 2021-12-02 at 15 32 03

We should be able align this behaviour dynamically keeping in mind the huge amount of different fields and scenarios possible when it comes to smart contracts and ABIs.
@JagoFigueroa JagoFigueroa added the Enhancement ✨ Design or functionality improvement label Dec 2, 2021
@JagoFigueroa JagoFigueroa added this to New Issues in Safe Apps via automation Dec 2, 2021
@dasanra dasanra moved this from New Issues to Product backlog in Safe Apps Dec 3, 2021
@dasanra dasanra moved this from Product backlog to Current sprint in Safe Apps Dec 16, 2021
@yagopv yagopv self-assigned this Jan 3, 2022
@yagopv yagopv moved this from Current sprint to Development in progress in Safe Apps Jan 3, 2022
@yagopv yagopv moved this from Development in progress to Code review and dev test in Safe Apps Jan 3, 2022
@yagopv yagopv mentioned this issue Jan 3, 2022
Merged
@yagopv yagopv assigned dasanra and unassigned dasanra Jan 10, 2022
@yagopv yagopv moved this from Code review and dev test to Ready for QA in Safe Apps Jan 10, 2022
@JagoFigueroa JagoFigueroa moved this from Ready for QA to QA in progress in Safe Apps Jan 10, 2022
@JagoFigueroa JagoFigueroa moved this from QA in progress to QA done in Safe Apps Jan 10, 2022
Safe Apps automation moved this from QA done to Closed Jan 10, 2022
@dasanra dasanra mentioned this issue Jan 13, 2022
Merged
@rmeissner rmeissner removed this from Closed in Safe Apps May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
Enhancement ✨ Design or functionality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TX BUILDER] Align Field Styles safe-global/safe-react-apps
3 participants
@yagopv @dasanra @JagoFigueroa