Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make manifest field non responsive when it fails to be fetched #272

Closed
JagoFigueroa opened this issue Jan 13, 2022 · 0 comments · Fixed by 5afe/safe-react#3366
Closed

Make manifest field non responsive when it fails to be fetched #272

JagoFigueroa opened this issue Jan 13, 2022 · 0 comments · Fixed by 5afe/safe-react#3366
Assignees
@yagopv
Labels
Bug 🐛 Something isn't working Minor

Comments

@JagoFigueroa
Copy link
Contributor

Description

Extremely trivial issue. When trying to load an app without a manifest, it fails to be fetched as expected but the field is still responsive as if we could input in it.

Steps to reproduce

  1. Try to load an invalid custom app (https://ipf.infura.io/ipfs/QmSddkqicov3HC1Urzv5AKPy2S7KqcnMQR5fjBnrFs2Z7A)
  2. Click on manifest field

Expected result

Non responsive, message error still in red when clicking

Obtained result

Screen.Recording.2022-01-13.at.09.58.11.mov
@JagoFigueroa JagoFigueroa added Bug 🐛 Something isn't working Minor labels Jan 13, 2022
@JagoFigueroa JagoFigueroa added this to New Issues in Safe Apps via automation Jan 13, 2022
@dasanra dasanra moved this from New Issues to Bugs in Safe Apps Jan 14, 2022
@yagopv yagopv moved this from Bugs to Development in progress in Safe Apps Jan 24, 2022
@yagopv yagopv mentioned this issue Jan 24, 2022
Merged
@yagopv yagopv moved this from Development in progress to Code review and dev test in Safe Apps Jan 24, 2022
@yagopv yagopv self-assigned this Jan 24, 2022
@yagopv yagopv moved this from Code review and dev test to Ready for QA in Safe Apps Jan 25, 2022
@JagoFigueroa JagoFigueroa moved this from Ready for QA to QA in progress in Safe Apps Jan 25, 2022
@JagoFigueroa JagoFigueroa moved this from QA in progress to QA done in Safe Apps Jan 25, 2022
@JagoFigueroa JagoFigueroa moved this from QA done to QA in progress in Safe Apps Jan 25, 2022
@JagoFigueroa JagoFigueroa moved this from QA in progress to QA done in Safe Apps Jan 25, 2022
Safe Apps automation moved this from QA done to Closed Jan 25, 2022
@rmeissner rmeissner removed this from Closed in Safe Apps May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
Bug 🐛 Something isn't working Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Safe App name TextField from readonly to disabled 5afe/safe-react
2 participants
@yagopv @JagoFigueroa