Address Book Suggestions

[matextrem]

closes #916

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app

[lukasschor]

Not really related to this PR, but this input validation for the Custom Transaction is wrong, the value can indeed be 0. Maybe we can fix this in this PR, but if it takes more than half an hour or so, I would suggest creating a new ticket and prioritizing it in the backlog.

[lukasschor]

Other than that it looks good to me. :)

[matextrem]

@lukasschor The thing is that you can just leave empty the field if you don’t want to add a value. That’s the reason why I thought if you add a value it is because is greater than 0. Otherwise you can leave it empty. Anyway, I can change the validator to support 0 as a valid value.

[lukasschor]

Yeah I think we should change it (if it's little work), as it's not clear that the field can be empty (we even show a * which usually means it's a mandatory field).

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app

[fernandomg]

I left a couple of observations. I don't think they're mandatory. But if there's time to make the change, I prefer we go with that approach.

[francovenica]

@matextrem @lukasschor Questions.

1-You can select not only contracts that have an ABI but also other types of contracts like other safes or tokens contracts. I'm assuming that the system has no way to tell that they are different (all contracts I suppose) right?

2-In the Contract interaction form for smart contracts, if you pick an address and the try to "re pick" another it wont let you, it won't show the address book suggestions again. This does not happen for the "custom Tx" form, where even if you pic an address you can double click in the field and the address book suggestions will popUp again.
I don't remember if it always worked like that, but can we make the Smart contract form to suggest another addresses even if you already picked an address?

[lukasschor]

1. is fine, users might want to interact with safe contracts or token contracts as well.

2. yeah that would be nice

[francovenica]

@matextrem It would be possible to do the number 2?

Now if you think it takes a long time then I can create a new ticket and close this one.

[matextrem]

@francovenica Yup, I think we could create another ticker and assign it to me since that thing is not related to this ticket itself and it always worked this way.

[francovenica]

Created the #1080 for point 2 then.

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app

[matextrem]

@mikheevm could you please approve this PR?

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app

[gnosis-info]

Travis automatic deployment:
https://pr1064--safereact.review.gnosisdev.com/app