(Feature) Advanced Settings - Safe Details #1074
Conversation
there's a lot of duplicated code, just copying functionalities and building basic structure for the section
|
Current status:
|
|
Travis automatic deployment: |
# Conflicts: # src/routes/safe/store/actions/fetchSafe.ts # src/routes/safe/store/models/safe.ts # src/routes/safe/store/reducer/safe.ts
Not so sure about how robust the fix is. But allow me to continue developing
- changed `remoteModules` in favor of `remoteModulesPaginated`, so we can properly have track of the `prevModule` for every module - refactored how module is stored from an array of `moduleAddress`es, to an array of `[moduleAddress, prevModuleAddress]` - Implemented the RemoveModule by copying the `RemoveSafeModule` implementation - TODO: display data
|
disable module (typo in modal title fixed)
view without modules |
| By removing a Module you will sign a new Safe Transaction. The Safe will not be able to interact with it | ||
| any longer until it is enabled again through a new Safe Transaction. |
There was a problem hiding this comment.
Can someone please review this message?
|
Travis automatic deployment: |
|
For the side menu, please use this icon:
From: https://zpl.io/a8g9EgK |
|
For the copy, you can use this: After removing this module, any feature or app that uses this module might no longer work. If this Safe requires more then one signature, the module removal will have to be confirmed by other owners as well. |
This needs a |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
There was a problem hiding this comment.
Re tested the same way as before, adding and deleting a module
The steps to add a module now are:
-Create a contrac interaction
-Your own safe as recipient
-The ABI in this page
-Use method "enableModule"
-This module address as input 0x34cfac646f301356faa8b21e94227e3583fe3f5f
-Sign the tx
Had to sign to add the module and delete it.
Adding and removal worked just fine
|
@lukasschor, @mikheevm this is ready to be re-reviewed |
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/index.tsx
Outdated
Show resolved
Hide resolved
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR closes #934, by:
Advancedsection under the Settings tabsit's a WIP, still, need to clean-up theAdvancedcomponents and usesafe-react-componentswhere possibleAlso:
safe-react-componentsdecodedDatafordisableModuleis not expected, so nothing is displayed in the transaction details