Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

sapp iframe size #1081

Merged
merged 5 commits into from
Jul 3, 2020
Merged

sapp iframe size #1081

merged 5 commits into from
Jul 3, 2020

Conversation

nicosampler
Copy link
Contributor

closes #1058.

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1081--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

francovenica commented Jun 30, 2020

The height is 550px as requested

I've checked Compound, Aave, Request, Sablier and the Tx builder, checking it looks good with the new size.

Looks good to me

Before/after:
image.png

image.png

@lukasschor
Copy link
Member

image

This distance is bigger on the apps tab than all other tabs. Maybe we can also adjust that to increase the amount of screen estate for the Safe Apps.

text="These are third-party apps, which means they are not owned, controlled, maintained or audited by Gnosis. Interacting with the apps is at your own risk."
textSize="sm"
/>
<MarginTop>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you just don't extend Centered component to have margin?

@nicosampler nicosampler self-assigned this Jul 1, 2020
@nicosampler nicosampler added the WIP label Jul 1, 2020
@gnosis-info
Copy link

Travis automatic deployment:
https://pr1081--safereact.review.gnosisdev.com/app

src/routes/safe/components/Apps/index.tsx Outdated Show resolved Hide resolved
@gnosis-info
Copy link

Travis automatic deployment:
https://pr1081--safereact.review.gnosisdev.com/app

src/routes/safe/components/Apps/index.tsx Outdated Show resolved Hide resolved
@gnosis-info
Copy link

Travis automatic deployment:
https://pr1081--safereact.review.gnosisdev.com/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1081--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 822903c into development Jul 3, 2020
@mmv08 mmv08 deleted the issue-1058 branch July 3, 2020 10:12
@lukasschor lukasschor removed the WIP label Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe Apps] Increase iframe height
5 participants