This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Updates bnc-notify version and adds support for GridPlus Lattice #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheckcla |
|
While Lattice looks like a very promising wallet option, I don't think it should be set as a "preferred" wallet right from the start. So I would set "preferred" to |
|
@lukasschor removed in |
alex-miller-0
force-pushed
the
gridplus/lattice
branch
3 times, most recently
from
33df6ac
to
55ef8e8
Compare
For more information on the GridPlus Lattice, see https://gridplus.io/lattice
alex-miller-0
force-pushed
the
gridplus/lattice
branch
from
55ef8e8
to
c856167
Compare
|
@lukasschor everything has been updated! Sorry if you got a bunch of notifications related to my rebasing. 😬 |
fernandomg
approved these changes
Oct 29, 2020
|
This PR will be handled in this internal branch so it's easier to solve conflicts with development branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Lattice is GridPlus' next generation hardware wallet. It is an always-online device with physically separated compute environments which provide unmatched security. For more information, see https://gridplus.io/lattice
About this PR
This PR adds the Lattice as a wallet option for bnc-notify. It also bumps the version of bnc-notify to the first version that includes Lattice support.
Note that a (nearly) identical integration was added to Curve. That pull request has a bunch of photos documenting what it is like to connect to and use an app with the Lattice and
bnc-notify.