Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Uses addressbook names in the review remove owner #1631

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 18, 2020

Closes #1558 and #1606 by:

  • Using the addressbook entries for displaying the owners on the review delete owner component

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 18, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

Looks good to me

image.png

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@gnosis-info
Copy link

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 592999d into development Nov 19, 2020
@dasanra dasanra deleted the fix/remove-owners-unknown-names branch November 19, 2020 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace owner modal is not showing the owners names properly
4 participants