This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Text ellipsis for sApp description #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Jun 30, 2021
| overflow: hidden; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 3; | ||
| -webkit-box-orient: vertical; |
There was a problem hiding this comment.
This won't work in Firefox, will it?
There was a problem hiding this comment.
Yes! Actually it's working well in FF.
I've tested it in Brave, Opera, Chrome and FF.
https://drafts.csswg.org/css-overflow-3/#webkit-line-clamp
There was a problem hiding this comment.
Oh, awesome! Let's merge it then. Thanks, Agustin!
katspaugh
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2478
How this PR fixes it
By adding an ellipsis to the description. We show 3 lines (max) and add a ellipsis at the end.
How to test it
Screenshots