Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Use staging and dev links in the network menu #2508

Merged
merged 2 commits into from
Jul 3, 2021
Merged

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2497.

How this PR fixes it

Adds staging and dev URLs in the network configs.

How to test it

Open the network menu and click on a link, then go back. Repeat for each of the links.

@katspaugh katspaugh requested a review from dasanra July 1, 2021 14:10
@@ -22,9 +22,11 @@ const rinkeby: NetworkConfig = {
environment: {
dev: {
...baseConfig,
safeUrl: 'https://safe-team.dev.gnosisdev.com/app/',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one that differs from staging.

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 7 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@@ -22,9 +22,11 @@ const mainnet: NetworkConfig = {
environment: {
dev: {
...baseConfig,
safeUrl: 'https://safe-team.staging.gnosisdev.com/app/',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is still working (don't know why) but is deprecated. The recommended way is to use the same structure than on the other domains.

https://safe-team-mainnet.staging.gnosisdev.com/app/

Same case below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed! ✅

@francovenica
Copy link
Contributor

The links are fine in this pr, they all take to https://safe-team-[NETWOKR].staging.gnosisdev.com/app/#/welcome. So it looks good ot me

Note:
I'll check it again once this change is deployed in dev and then make sure that in prod the links are still point to prod env.

@katspaugh katspaugh merged commit 8ae6805 into dev Jul 3, 2021
@katspaugh katspaugh deleted the fix-network-links branch July 3, 2021 06:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[L2] Network switching on localhost/dev/staging
3 participants