Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Address book: validate chain id; fix download button #2509

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Address book: validate chain id; fix download button #2509

merged 2 commits into from
Jul 5, 2021

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2464.

How this PR fixes it

Checks if chain id exists in the list of supported chains.

I've also fixed the Download button in the export modal. The clickable area wasn't covering the whole button.

How to test it

Export the AB on the Arbitrum branch, try to import on this PR's branch. It will not recognize Arbitrum because it's not merged yet.

Screenshots

Screenshot 2021-07-01 at 16 30 45

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

@francovenica
Copy link
Contributor

francovenica commented Jul 2, 2021

Issue:
If there there is a blank space in front of the chainID number the system will take that as a not valid chainID (for example [ADDRESS],[NAME], 56). Not a big issue but pretty annoying

Currently in prod we trim the blank spaces for the chainID so a ", 4" is a valid chainID in prod.

@katspaugh
Copy link
Member Author

@francovenica fixed ✅

@francovenica
Copy link
Contributor

Looks good to me

@katspaugh katspaugh merged commit e006cdd into dev Jul 5, 2021
@katspaugh katspaugh deleted the fix-ab branch July 5, 2021 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AB - File importing is not checking for ChainID
3 participants