Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature: Retrieve Safe Apps only guaranteed to work on the current client #3273

Merged
merged 7 commits into from Jan 14, 2022

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 10, 2022

What it solves

Resolves #2672 where apps limited access to embedding it as an iframe to specific origins

How this PR fixes it

So now, for GET /safe-apps, there's a clientUrl param available on the client gateway and config service. It takes a hostname with a protocol, and the returned apps are ensured to work on this client.

How to test it

  1. Load the mainnet Safe deployment
  2. Zerion or 1inch shouldn't be on the list of safe apps

@mmv08 mmv08 changed the title Feature: Retrieve Safe Apps only guaranteed to work on the current origin Feature: Retrieve Safe Apps only guaranteed to work on the current client Jan 10, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

package.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 11, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1697661767

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Safe Balances Safe Balances

@coveralls
Copy link

coveralls commented Jan 11, 2022

Pull Request Test Coverage Report for Build 1697629199

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.44%

Totals Coverage Status
Change from base Build 1696744828: 0.0%
Covered Lines: 3123
Relevant Lines: 8571

💛 - Coveralls

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merge branch 'dev' of github.com:gnosis/safe-react into feature/pass-client-url-when-retrieving-safe-apps
@mmv08
Copy link
Member Author

mmv08 commented Jan 14, 2022

Screen.Recording.2022-01-14.at.15.22.40.mov

The issue reported by @JagoFigueroa in the original issue was because the build used prod backend where correct accessControls are not set yet. When using staging endpoints it works perfectly (check video)

@JagoFigueroa
Copy link

Thank you @mikheevm ! I think it's more than fair to close this ticket then ;)

@mmv08 mmv08 merged commit 88f93ab into dev Jan 14, 2022
@mmv08 mmv08 deleted the feature/pass-client-url-when-retrieving-safe-apps branch January 14, 2022 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Safe apps cannot be loaded in the desktop app
6 participants