Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: update Ledger instructions #3337

Merged
merged 1 commit into from Jan 21, 2022
Merged

Fix: update Ledger instructions #3337

merged 1 commit into from Jan 21, 2022

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2876

How this PR fixes it

I've updated the image (took it from Ledger's docs), added links to their docs and updated the name of the setting (it's now called Blind Signing).

Screenshots

Screenshot 2022-01-20 at 16 08 56

@katspaugh katspaugh requested a review from mmv08 January 20, 2022 15:12
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the photographer 😉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1724088469

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.968%

Totals Coverage Status
Change from base Build 1723311410: 0.0%
Covered Lines: 3115
Relevant Lines: 8685

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1724124042

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@francovenica
Copy link
Contributor

The Image is there. Looks good

Note: I still have an "old legder" so the original image would still work for people like me 😄

@katspaugh
Copy link
Member Author

@francovenica think we should add smith like "(formerly known as Display Transaction Data)"?

@iamacook
Copy link
Member

think we should add smith like "(formerly known as Display Transaction Data)"?

Probably good to cover all bases.

@katspaugh
Copy link
Member Author

On the other hand, the docs I linked mention what this setting used to be called, so I think it's fine.

@katspaugh katspaugh merged commit cf0b004 into dev Jan 21, 2022
@katspaugh katspaugh deleted the fix-ledger-docs branch January 21, 2022 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
@francovenica
Copy link
Contributor

francovenica commented Jan 21, 2022

If you want to add something like "(Called Display Transaction Data in older models)". But I'm pretty sure is not that big of a deal, there isn't that many options inside the Eth app for ledger, not much room for the user to mess that one up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated ledger connection image
4 participants