Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Optimize dockerfile #3386

Merged
merged 1 commit into from Jan 31, 2022
Merged

Optimize dockerfile #3386

merged 1 commit into from Jan 31, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jan 28, 2022

  • Copy package.json and yarn.lock on the same step
  • Delete apt database after installing dependencies

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mmv08
Copy link
Member

mmv08 commented Jan 28, 2022

Delete apt database after installing dependencies

why is it needed?

@github-actions
Copy link

Deployment links

🟠 Rinkeby ⚪ Mainnet 🟣 Polygon 🟡 BSC ⚫ Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1762439426

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.632%
Totals Coverage Status
Change from base Build 1760720190: 0.0%
Covered Lines: 3187
Relevant Lines: 8484
💛 - Coveralls

@Uxio0
Copy link
Member Author

Uxio0 commented Jan 28, 2022 •
edited

Delete apt database after installing dependencies

why is it needed?

Just making image smaller, it's a common practice on dockerfiles

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1762469516

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Read-only transaction creation and review

iamacook
iamacook approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

katspaugh
katspaugh approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

mmv08
mmv08 approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buen código señor

@Uxio0 Uxio0 merged commit 4763d51 into dev Jan 31, 2022
@Uxio0 Uxio0 deleted the optimize-docker-image branch January 31, 2022 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

@mmv08 mmv08 mmv08 approved these changes

@iamacook iamacook iamacook approved these changes

@dasanra dasanra dasanra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Uxio0 @mmv08 @coveralls @katspaugh @iamacook @dasanra