Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

feat: Include pinned safe apps in dashboard widget #3849

Merged
merged 2 commits into from May 4, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Part of #3693

How this PR fixes it

Pinned safe apps are included with a given weight when ranking tracked safe apps for the dashboard widget.

How to test it

  1. Open the Safe app
  2. Navigate to the dashboard
  3. Observe that pinned apps are displayed within the safe apps widget

Screenshots

Screenshot 2022-05-03 at 13 13 36

@github-actions
Copy link

github-actions bot commented May 3, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented May 3, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented May 3, 2022

Pull Request Test Coverage Report for Build 2263923491

  • 19 of 21 (90.48%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 35.368%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dashboard/SafeApps/Grid.tsx 0 1 0.0%
src/routes/safe/components/Apps/trackAppUsageCount.ts 19 20 95.0%
Totals Coverage Status
Change from base Build 2262452500: 0.02%
Covered Lines: 3609
Relevant Lines: 9254

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented May 3, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@francovenica
Copy link
Contributor

francovenica commented May 4, 2022

I thought I tested a similar ticket like this before, I don't know what is new here.
This is what I checked and you can tell me if I'm missing something.

Pinned apps are always first in the safe apps witdget
The ranking still work between pinned apps (most visited apps show first between pinned apps)
The ranking system still works fine between non-pinned apps
The if the apps have no ranking they will show randomly in the rest of the slots

If this covers what this ticket worked on I'd agree to pass this ticket to QA done.

image

@usame-algan usame-algan merged commit cbd0a5f into dev May 4, 2022
@usame-algan usame-algan deleted the dashboard-pinned-apps branch May 4, 2022 07:32
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants