You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the personal edition the nonce is increased even in case the transaction fails. We should have the same behavior for team edition: mark a transaction as executed even in case it fails and signal a failing transaction with an event. This prevents that transactions, which might not work at the time of transaction submission to remain forever in pending state and get lost, which is a potential security issue. Also execTransactionIfApproved should then return the success status of the transaction.
The text was updated successfully, but these errors were encountered:
I was asking myself if it would make more sense to provide a clearApproval. Mainly because if by any change the required gas changes and the transaction fails because of not enough gas, all confirmations have to be gathered again.
@Georgi87 it would be more that each owner can clear his own approval (actually it shouldn't be required to be an owner to clear your approval, so that you can remove your approval even after you are not an owner anymore)
In the personal edition the nonce is increased even in case the transaction fails. We should have the same behavior for team edition: mark a transaction as executed even in case it fails and signal a failing transaction with an event. This prevents that transactions, which might not work at the time of transaction submission to remain forever in pending state and get lost, which is a potential security issue. Also execTransactionIfApproved should then return the success status of the transaction.
The text was updated successfully, but these errors were encountered: