Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering transactions by modified #63

Closed
lukasschor opened this issue Feb 10, 2020 · 2 comments
Closed

Allow filtering transactions by modified #63

lukasschor opened this issue Feb 10, 2020 · 2 comments
Assignees
@Uxio0

Comments

@lukasschor
Copy link
Member

lukasschor commented Feb 10, 2020 •
edited by Uxio0

See 5afe/safe-react#517 for details.

Create a new filter for transactions/ endpoint to filter transactions modified after/before a timestamp:

  • modified__lt
  • modified__gt
  • modified__gte
  • modified__lte

It will allow ISO 8601 datetimes like:

  • 2020-02-27T10:46:15Z
  • 2020-02-27T10:46:15+00:00
  • 2020-02-27 10:46:15Z

Backend needs to be adjusted to update modified on transactions when a new confirmation is added to the database.
@pablofullana pablofullana mentioned this issue Feb 10, 2020
Closed
@Uxio0 Uxio0 changed the title Optimize network requests for transactions tab Allow filtering transactions by modified Feb 27, 2020
@Uxio0
Copy link
Member

Uxio0 commented Feb 27, 2020

@lukasschor @rmeissner I updated the issue with the implementation of the endpoint

@Uxio0 Uxio0 self-assigned this Feb 27, 2020
@lukasschor
Copy link
Member Author

Closing this as frontend seems to already have implemented this. Feel free to reopen if there is some work outstanding on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Uxio0 @lukasschor