Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC - The safe connects with itself after refreshing #2790

Closed
francovenica opened this issue Nov 10, 2023 · 2 comments · Fixed by #2793
Closed

WC - The safe connects with itself after refreshing #2790

francovenica opened this issue Nov 10, 2023 · 2 comments · Fixed by #2793
Assignees
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@francovenica
Copy link
Contributor

Bug description

After the user connects with WC using a wallet on his phone (like MM), then if refreshes the page, the WC pairing feature shows that the safe is connected with itself

This issue is in current prod 1.21.1

Environment

  • Browser: Chrome
  • Wallet: WC (MM phone app) and WC pairing
  • Chain: Any
  • Env: Current prod 1.21

Steps to reproduce

  1. Open the onboard modal and choose WC
  2. Use your MM phone app and scan the QR to connect
  3. Refresh the page manually

Expected result

The WC should reconnect with the account you were connected before the refreshing

Obtained result

Now is the safe itself connected instead

Screenshots

WC wrong pairing

@francovenica francovenica added bug Something isn't working major Major bug (to be solved in the next release) labels Nov 10, 2023
@usame-algan
Copy link
Member

Maybe this helps with debugging but the issue only happens for me if the connected wallet is an owner of the safe

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 20, 2023

The bug was fixed.
Wallet connected via WC is not part of dapps WC any more
Checked:

  1. connection with MM mobile app + app refresh
  2. connection with MM mobile app + Cowswap/Uniswap connected via dapps WC
  3. safe-as an owner connected via WC + MM mobile app connected via WC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants