test: queue transaction with recommended nonce #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3acbaa3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://619805b8.web-core.pages.dev |
| Branch Preview URL: | https://fix-e2e-create-tx.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
DiogoSoaress
requested review from
iamacook
and removed request for
usame-algan
iamacook
approved these changes
Oct 28, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
After investigation on the failing E2E tests
What's happening is that a transaction was already queued with the same data, thus it won't be duplicated and consequently it won't appear in the Dashboard as the most recent transaction with that nonce. (That's why it start failing out of the sudden - we are only randomizing 20 possible values in the test)
How this PR fixes it
We stop queuing transactions with the same nonce and instead queue transactions with the recommended nonce and verify the transaction is queued in the Single Tx details page instead of the Dashboard.
After signing the transaction, we follow to the SingleTx page by clicking the notification where we can see the newly queued transaction.