Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide widget when no Safe address exists #1019

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix: hide widget when no Safe address exists #1019

merged 1 commit into from
Nov 1, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Nov 1, 2022

What it solves

Resolves empty widget container in header.

How this PR fixes it

If no Safe address exists, the widget is not rendered.

How to test it

Open Safe creation and observe no empty widget container:

image

@iamacook iamacook self-assigned this Nov 1, 2022
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c83332
Status: ✅  Deploy successful!
Preview URL: https://34f91742.web-core.pages.dev
Branch Preview URL: https://hide-widget.web-core.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants