Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: social sharing meta tags #980

Merged
merged 5 commits into from
Nov 1, 2022
Merged

add: social sharing meta tags #980

merged 5 commits into from
Nov 1, 2022

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 25, 2022

What it solves

Adds social sharing meta tags to display a preview image and description when sending a link to a safe on messaging / facebook / twitter

How to test it

Send a link to the deployed version on slack / twitter

Analytics changes

None

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3721efa
Status: ✅  Deploy successful!
Preview URL: https://96a125a7.web-core.pages.dev
Branch Preview URL: https://change-og-image.web-core.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but does the image have to be a JPG?
PNG would look nicer.
And please run it through https://tinypng.com to reduce the size.

@schmanu
Copy link
Member Author

schmanu commented Oct 25, 2022

The code looks good, but does the image have to be a JPG? PNG would look nicer. And please run it through https://tinypng.com to reduce the size.

done!

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let's merge it now, and check again once the new domain goes live.

@JagoFigueroa
Copy link

After talking with Manu the testing for this ticket will be done after it is deployed. Thanks!

@schmanu schmanu merged commit b305ab5 into dev Nov 1, 2022
@schmanu schmanu deleted the change-og-image branch November 1, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants