-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: social sharing meta tags #980
Conversation
Deploying with Cloudflare Pages
|
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but does the image have to be a JPG?
PNG would look nicer.
And please run it through https://tinypng.com to reduce the size.
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, let's merge it now, and check again once the new domain goes live.
After talking with Manu the testing for this ticket will be done after it is deployed. Thanks! |
What it solves
Adds social sharing meta tags to display a preview image and description when sending a link to a safe on messaging / facebook / twitter
How to test it
Send a link to the deployed version on slack / twitter
Analytics changes
None