Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Crawling non-ASCII characters (URL) #4

Open
safesploit opened this issue Nov 15, 2022 · 1 comment
Open

Bug: Crawling non-ASCII characters (URL) #4

safesploit opened this issue Nov 15, 2022 · 1 comment

Comments

@safesploit
Copy link
Member

When crawling the Japanese Wikipedia ja.wikipedia.org/wiki/メインページ the following URL is indexed
https://ja.wikipedia.org/wiki/%E3%83%A1%E3%82%A4%E3%83%B3%E3%83%9A%E3%83%BC%E3%82%B8

@dehlirious
Copy link

dehlirious commented Mar 31, 2023

Hey, I've written this up and it works, but am I missing anything?

Tested and it functions fine, tested a url with a ` character(only thing not covered by htmlspecialchars) and it didn't break it

I've also noticed that html tags are removed from URL titles(if title says "<b>Hi" it results in "Hi", which kindof is an issue depending on the circumstance, I'd rather it be processed with htmlspecialchars than removed. Anyway,

Line 88 of crawl-manual insert
$url = htmlspecialchars(urldecode($url),ENT_QUOTES, "UTF-8");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants