Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

Using sentinel config fails with journal queries #16

Closed
jonfox opened this issue Aug 25, 2017 · 4 comments
Closed

Using sentinel config fails with journal queries #16

jonfox opened this issue Aug 25, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@jonfox
Copy link
Contributor

jonfox commented Aug 25, 2017

When I configure the plugin to use sentinel, I get failures on journal queries. The problem seems to be that in EventsByPersistenceId, EventsByTagSource, and PersistenceIdsSource, the code in preStart() to create the subscription assumes the standard config, rather than sentinel. I have it working by changing:

        subscription = RedisPubSub(host = RedisUtils.host(conf),
          port = RedisUtils.port(conf),
          channels = Seq(identifiersChannel),
          patterns = Nil,
          authPassword = RedisUtils.password(conf),
          onMessage = callback.invoke)(system)

to

        subscription = RedisPubSub(host = redis.host,
          port = redis.port,
          channels = Seq(identifiersChannel),
          patterns = Nil,
          authPassword = redis.password,
          onMessage = callback.invoke)(system)

Does that fix seem reasonable?

Thanks -

@satabin satabin self-assigned this Aug 25, 2017
@satabin satabin added the bug label Aug 25, 2017
@satabin satabin added this to the 0.3.0 milestone Aug 25, 2017
@satabin
Copy link
Contributor

satabin commented Aug 25, 2017

Hi,

Indeed, I wrote the journal query part as if only standard configuration exists.
Reusing the redis settings seems the best way to do it instead of assuming it is standard config.

You can either open a pull request or I will do it. as you wish.

@jonfox
Copy link
Contributor Author

jonfox commented Aug 25, 2017

Thanks, see #17

@satabin
Copy link
Contributor

satabin commented Aug 28, 2017

Closed by #17

@satabin satabin closed this as completed Aug 28, 2017
@satabin
Copy link
Contributor

satabin commented Aug 28, 2017

0.3.0-SNAPSHOT updated with this fix. 0.3.0 release planned on Thursday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants