New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dropping folders #17
Conversation
fda25fe
to
6eb0304
Compare
Thank you for the pull request. This is a very welcomed feature (that I had thought of supporting in the future). I will do some testing on my side and merge. Thanks. Happy Hacktoberfest! |
Hi @kevinleedrum great work. I tested it and works perfectly. My only concern is that you are using |
Good point. I will convert it to promises. |
6eb0304
to
f0f0585
Compare
f0f0585
to
f3e716c
Compare
@safrazik I've replaced |
@kevinleedrum Thank you for your work. |
My two cents on that: So, I would rather prefer that kind of consistence |
Sure. I haven't seen a better (short) explanation than this for const and let. Thanks. |
@kevinleedrum Support for dropping folders landed in version 1.3 Rock Wren. Thanks for your contribution. |
Happy Hacktoberfest! 馃巸
This PR adds the ability to drop folders, which will be parsed recursively for files.
Before:鈽癸笍
After: 馃槃