Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify-able aria labels #1030

Open
adelriosantiago opened this issue Dec 23, 2019 · 1 comment · May be fixed by #988
Open

Modify-able aria labels #1030

adelriosantiago opened this issue Dec 23, 2019 · 1 comment · May be fixed by #988

Comments

@adelriosantiago
Copy link

adelriosantiago commented Dec 23, 2019

Is your feature request related to a problem? Please describe.
The aria-label for new elements is always "Search for option" however this will trigger an accessibility issue if the developer wants a different placeholder text (for example "Pick from the list"). In this scenario the placeholder and the aria-label would not match.

Describe the solution you'd like
I would expect to be able to pass the desired label as a prop.

Additional context
Here is the screenshot of the default aria label:
image

And the line of this default text is here: https://github.com/sagalbot/vue-select/blob/master/src/components/Select.vue#L977

@sagalbot sagalbot linked a pull request Mar 8, 2020 that will close this issue
@chrisdant
Copy link

This would be great to have! Essential to having a good user experience for screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants