Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce + taggable bug #1091

Merged
merged 3 commits into from Mar 11, 2020
Merged

fix: reduce + taggable bug #1091

merged 3 commits into from Mar 11, 2020

Conversation

sagalbot
Copy link
Owner

@sagalbot sagalbot commented Mar 9, 2020

Resolves #1089
Resolves #993

@sagalbot sagalbot marked this pull request as ready for review March 9, 2020 18:22
@sagalbot
Copy link
Owner Author

sagalbot commented Mar 9, 2020

New regression:

      <v-select
        v-model="selected"
        :options="[]"
        label="label"
        taggable
        push-tags
        :reduce="name => name.value"
        :create-option="label => ({ label, value: -1 })"
        @input="tag => tags.push(tag)"
      />

Mar-09-2020 11-25-58

Caused when pushTags creates an option without a unique reduce value.

@sagalbot sagalbot merged commit 518e191 into master Mar 11, 2020
@sagalbot sagalbot deleted the bug/taggable-reduce branch March 11, 2020 04:11
@github-actions
Copy link

🎉 This PR is included in version 3.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant