Location extension #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sagar-viradiya
commented
May 6, 2021
sagar-viradiya
commented
- Add location extension for last location and location flow
- Add instrumentation test for location extensions
- Modify CI script to spin up devices with playstore
- Add location permission in test activity
sagar-viradiya
force-pushed
the
sagar/ktx/location
branch
from
55eb358
to
058b049
Compare
- Add location extension for last location and location flow - Add instrumentation test for location extensions - Modify CI script to spin up devices with playstore - Add location permission in test activity
- Fix wildcard import
- Separate emulators with playstore support(Google play services) - Skip location test on API levels below 24
- Exclude instrumentation tests for location module on API level 16, 19 and 21.
- Target API level 26 and 30 instead of 25 and 29 for instrumentation testing.
- Update API level from 30 to 29 as tests were failing on API level 30
sagar-viradiya
force-pushed
the
sagar/ktx/location
branch
from
058b049
to
55530ea
Compare
- Run location test only on API level 29 because there seems to problem with play services on API level below 29.
- Remove coroutine test dependency. - Add coroutine android dependency in the android test src set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.