New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aiodns pep484 + mypy support #25
Comments
Hi there! I'm afraid there are no plans, and patches wouldn't be acceptable at this stage because it would mean dropping Python < 3.5 support (AFAIK), which I'm not planning to do at the moment. |
@saghul fortunately dropping support for < 3.5 is unnecessary. Since you're still compatible with 2.x, we'll have to use type comments, which are compatible with both versions and are documented in the PEP. This way you could start using Mypy now, and even run it against 2.7, 3.3, 3.4, 3.5, and 3.6 in your Travis runs. Once the types are there, moving them to be proper annotations once you drop Python 2 support will be very easy. But we don't have to do that yet. |
Oh, alright then! Bring them on :-) |
Working on it: |
Fixed by #27 |
Is there any plan for PEP 484 type annotation support in aiodns?
PEP 484: https://www.python.org/dev/peps/pep-0484/
mypy: http://mypy-lang.org/
If I were to do the diff, would the PR be accepted?
The text was updated successfully, but these errors were encountered: