Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundled c-ares #8

Closed
WGH- opened this issue Mar 25, 2014 · 4 comments
Closed

Bundled c-ares #8

WGH- opened this issue Mar 25, 2014 · 4 comments

Comments

@WGH-
Copy link
Contributor

WGH- commented Mar 25, 2014

Why c-ares is bundled, anyway? Wouldn't it better to use system one?
@saghul
Copy link
Owner

saghul commented Mar 25, 2014

It's not so easy to install on every platform and since it's quite small I went with embedding it and doing a static build. I'm also floating a patch for skipping bogus resolvers on windows, which I think it ended up being accepted upstream.

To put it in a single word: convenience.

@saghul
Copy link
Owner

saghul commented Mar 26, 2014

That said, I'd take a patch allowing to build pycares against a system provided c-ares, I guess.

@fsteinel
Copy link

I've added my try in the pull request #14

@saghul
Copy link
Owner

saghul commented Aug 31, 2015

We now patch the bundled c-ares, this is no longer an option: #14 (comment)

@saghul saghul closed this as completed Aug 31, 2015
@brizzbane brizzbane mentioned this issue Feb 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsteinel @saghul @WGH-