Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_modules is not being ignored #35

Closed
joadr opened this issue Sep 26, 2016 · 5 comments
Closed

node_modules is not being ignored #35

joadr opened this issue Sep 26, 2016 · 5 comments

Comments

@joadr
Copy link

joadr commented Sep 26, 2016

I've tried changing the settings to the previous way, but doesn't work either?.

Also, I've set my sublime to ignore the node_modules folder also, should this extension look at "folder_exclude_patterns" in sublime's settings?

@sagold
Copy link
Owner

sagold commented Sep 29, 2016

Hi joadr.

I will revert the ignore pattern to the previous one on the next update. The old setting is still working, but you have to restart sublime to load it correctly. And note that this is a regular expression. Some characters may have to be escaped in order to be valid.

As for using ignore folder patterns. I thought about this and would prefer to use this setting. Unfortunately sublime's settings do not support regex patterns. In my case, i am whitelisting specific node_modules, which is only possible through regex or tedious work. Another reason is, they describe different files. Sublime suggest files i want to edit, ffp suggest files i want to include. Those sets may not always be the same.

Hope this makes sense. Happy to hear other opinions.

@saschagehlich
Copy link

Any update on this one @sagold? This is a big show stopper for this plugin - it's caching >40k files in a medium sized project

@joadr
Copy link
Author

joadr commented Jan 17, 2017

I tried the solution provided by @sagold but didn't work for me... it's still showing the node_modules files:(

@sagold
Copy link
Owner

sagold commented Jan 20, 2017

I am using the following working configuration in my FuzzyFilePath-User-Settings:

"exclude_folders": ["node\\_modules\/(?!sz).*", "bower\\_components/.*/bower\\_components"],

I am planing to change the default and update FFP in the next week. Please let me know if your exclude_folders-settings are not applied.

Regards.
sagold

@sagold
Copy link
Owner

sagold commented Jan 20, 2017

Since version v0.3.1 node_modules are completly ignored by default: 1bf8fd8.

I hope this solves this issue.
Thank you for your feedback

@sagold sagold closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants