Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

Fixes #27 Ambiguous use of 'description' #28

Merged
merged 2 commits into from Sep 22, 2017

Conversation

briancprice
Copy link
Contributor

You may want to just add the description property to the tag class, but this was the least modification I could make. Thanks

@sahandnayebaziz
Copy link
Owner

First off... congratulations on your first PR! Looks great :)

This makes sense, we just need tag to conform to CustomStringConvertible through Renderable and this does just that.

But, since we are only working with tag now, maybe this makes more sense in the tag class itself as opposed to sitting as an extension. Can you delete this extension and just move the public var description: String { that returns render() into the tag class?

I can merge this in after :)

@sahandnayebaziz sahandnayebaziz self-assigned this Sep 22, 2017
@briancprice
Copy link
Contributor Author

Thanks! And thank you for writing this pod, saved me a ton of time generating HTML to convert to PDF for my app!

@sahandnayebaziz
Copy link
Owner

Perfect! Merging...

@sahandnayebaziz sahandnayebaziz merged commit f6dcb90 into sahandnayebaziz:master Sep 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants