Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer compiles #67

Closed
Fancy2209 opened this issue Nov 25, 2023 · 3 comments
Closed

No longer compiles #67

Fancy2209 opened this issue Nov 25, 2023 · 3 comments

Comments

@Fancy2209
Copy link

Cullprit is this function

static function filterFuncExpr(e:Expr):Expr {
		log("filterFuncExpr " + e);
		switch(e.expr) {
		case EVars(vars):
			log("EVars(" + vars + ")");
			var newVars:Array<Var> = vars.copy();
			for (v in vars) {
				log("v " + v);
				var names:Array<String> = v.name.names(v.type);
				log("names " + names);
				if (names != null) {
					newVars = newVars.concat(names.map(function(name) {
						return {
							name: name,
							type: macro:Float,
							expr: null,
							meta: null,
							isFinal: false
						};
					}));
				}
			}
			e.expr = EVars(newVars);
			return e;
		case _:
			log("others");
			return ExprTools.map(e, filterFuncExpr);
		}
	}

src/oimo/m/B.hx:182: lines 182-190 : error: { type : haxe.macro.ComplexType, name : String, meta : Null<haxe.macro.Metadata>, isFinal : Bool, expr : Null<haxe.macro.Expr> } has no field isStatic
src/oimo/m/B.hx:182: lines 182-190 : ... have: Array<{ type, name, meta, isFinal, expr }>
src/oimo/m/B.hx:182: lines 182-190 : ... want: Array<haxe.macro.Var>
src/oimo/dynamics/rigidbody/RigidBodyType.hx:6: characters 1-8 : Build failure

@Fancy2209 Fancy2209 changed the title No longer compiled No longer compiles Nov 25, 2023
@mrwedders
Copy link
Contributor

I've just made a pull request, but some new optional properties were introduced with Haxe 4.3 which just need to be added.

@Fancy2209
Copy link
Author

Oh, thanks!

@saharan
Copy link
Owner

saharan commented May 16, 2024

fixed in #69 !

@saharan saharan closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants