iscsi-test improvements

[bonzini]

Hi Ronnie,

here are some iscsi-test improvements.

1. return 77 if tests were skipped but none was failed;

2. skip some more tests on non-SBC devices;

3. fix building out-of-tree and some warnings from GCC.

Thanks for your awesome work on the tests!

[sahlberg]

Thanks Paolo.

Merged!

It is very ad-hoc for the time being but with time and care it can become a
pretty good testsuite I think.

regards
ronnie sahlberg

On Thu, Aug 30, 2012 at 8:41 AM, Paolo Bonzini notifications@github.comwrote:

Hi Ronnie,

here are some iscsi-test improvements.

1. return 77 if tests were skipped but none was failed;

2. skip some more tests on non-SBC devices;

3. fix building out-of-tree and some warnings from GCC.

Thanks for your awesome work on the tests!

You can merge this Pull Request by running:

git pull https://github.com/bonzini/libiscsi master

Or view, comment on, or merge it at:

#13
Commit Summary

• fix building out-of-tree
• iscsi-test: avoid declaring struct inside parameter list
• iscsi-test: do not test DPO/FUA for non-SBC devices
• iscsi-test: do not test read-only for non-SBC devices
• iscsi-test: prepare to return exit status 77 for skipped tests
• iscsi-test: return -2 when skipping tests

File Changes

• M Makefile.am (2)
• M test-tool/0103_read10_rdprotect.c (4)
• M test-tool/0104_read10_flags.c (19)
• M test-tool/0170_unmap_simple.c (4)
• M test-tool/0171_unmap_zero.c (4)
• M test-tool/0180_writesame10_unmap.c (2)
• M test-tool/0181_writesame10_unmap_unaligned.c (4)
• M test-tool/0182_writesame10_beyondeol.c (2)
• M test-tool/0183_writesame10_wrprotect.c (2)
• M test-tool/0184_writesame10_0blocks.c (2)
• M test-tool/0190_writesame16_unmap.c (2)
• M test-tool/0191_writesame16_unmap_unaligned.c (4)
• M test-tool/0192_writesame16_beyondeol.c (2)
• M test-tool/0193_writesame16_wrprotect.c (2)
• M test-tool/0194_writesame16_0blocks.c (2)
• M test-tool/0201_read16_rdprotect.c (1)
• M test-tool/0202_read16_flags.c (19)
• M test-tool/0211_read12_rdprotect.c (1)
• M test-tool/0212_read12_flags.c (19)
• M test-tool/0220_write16_simple.c (2)
• M test-tool/0221_write16_wrprotect.c (3)
• M test-tool/0222_write16_flags.c (21)
• M test-tool/0223_write16_0blocks.c (2)
• M test-tool/0224_write16_beyondeol.c (2)
• M test-tool/0230_write12_simple.c (2)
• M test-tool/0231_write12_wrprotect.c (3)
• M test-tool/0232_write12_flags.c (21)
• M test-tool/0233_write12_0blocks.c (2)
• M test-tool/0234_write12_beyondeol.c (2)
• M test-tool/0260_get_lba_status_simple.c (2)
• M test-tool/0264_get_lba_status_beyondeol.c (2)
• M test-tool/0290_write10_simple.c (2)
• M test-tool/0291_write10_wrprotect.c (3)
• M test-tool/0292_write10_flags.c (21)
• M test-tool/0293_write10_0blocks.c (2)
• M test-tool/0294_write10_beyondeol.c (2)
• M test-tool/0300_readonly.c (22)
• M test-tool/0310_writeverify10_simple.c (2)
• M test-tool/0311_writeverify10_wrprotect.c (3)
• M test-tool/0314_writeverify10_beyondeol.c (2)
• M test-tool/0320_writeverify12_simple.c (2)
• M test-tool/0321_writeverify12_wrprotect.c (3)
• M test-tool/0324_writeverify12_beyondeol.c (2)
• M test-tool/0330_writeverify16_simple.c (2)
• M test-tool/0331_writeverify16_wrprotect.c (3)
• M test-tool/0334_writeverify16_beyondeol.c (2)
• M test-tool/0340_compareandwrite_simple.c (2)
• M test-tool/0341_compareandwrite_mismatch.c (2)
• M test-tool/0343_compareandwrite_beyondeol.c (2)
• M test-tool/0350_orwrite_simple.c (2)
• M test-tool/0351_orwrite_wrprotect.c (3)
• M test-tool/0354_orwrite_beyondeol.c (2)
• M test-tool/0360_startstopunit_simple.c (2)
• M test-tool/0361_startstopunit_pwrcnd.c (2)
• M test-tool/0370_nomedia.c (2)
• M test-tool/0380_preventallow_simple.c (2)
• M test-tool/0381_preventallow_eject.c (3)
• M test-tool/0382_preventallow_itnexus_loss.c (3)
• M test-tool/0383_preventallow_target_warm_reset.c (3)
• M test-tool/0384_preventallow_target_cold_reset.c (3)
• M test-tool/0385_preventallow_lun_reset.c (3)
• M test-tool/0386_preventallow_2_it_nexuses.c (3)
• M test-tool/0390_mandatory_opcodes_sbc.c (3)
• M test-tool/1000_cmdsn_invalid.c (2)
• M test-tool/1010_datasn_invalid.c (2)
• M test-tool/1020_bufferoffset_invalid.c (2)
• M test-tool/iscsi-test.c (11)
• M test-tool/iscsi-test.h (2)

Patch Links

• https://github.com/sahlberg/libiscsi/pull/13.patch

• https://github.com/sahlberg/libiscsi/pull/13.diff

  —
  Reply to this email directly or view it on GitHubhttps://github.com/iscsi-test improvements #13.