Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in "update_nba_db": could not find function "my_time" #14

Closed
jedwards757 opened this issue May 20, 2021 · 4 comments · Fixed by #15
Closed

Error in "update_nba_db": could not find function "my_time" #14

jedwards757 opened this issue May 20, 2021 · 4 comments · Fixed by #15

Comments

@jedwards757
Copy link

jedwards757 commented May 20, 2021

library(hoopR)
future::plan("multisession")
update_nba_db(dbname = 'nba.sqlite',
              tblname = 'pbp',
              force_rebuild = TRUE)

Results in:

Error in my_time() : could not find function "my_time"

> sessionInfo()
R version 4.0.5 (2021-03-31)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19042)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252   
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C                          
[5] LC_TIME=English_United States.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] hoopR_1.0.1

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.6        compiler_4.0.5    pillar_1.6.1      tools_4.0.5       bit_4.0.4        
 [6] digest_0.6.27     memoise_2.0.0     RSQLite_2.2.7     jsonlite_1.7.2    lubridate_1.7.10 
[11] lifecycle_1.0.0   tibble_3.1.1      pkgconfig_2.0.3   rlang_0.4.11      DBI_1.1.1        
[16] parallel_4.0.5    xfun_0.22         fastmap_1.1.0     furrr_0.2.2       httr_1.4.2       
[21] stringr_1.4.0     dplyr_1.0.6       xml2_1.3.2        fs_1.5.0          generics_0.1.0   
[26] vctrs_0.3.8       tictoc_1.0.1      globals_0.14.0    bit64_4.0.5       tidyselect_1.1.1 
[31] glue_1.4.2        data.table_1.14.0 listenv_0.8.0     R6_2.5.0          fansi_0.4.2      
[36] parallelly_1.25.0 blob_1.2.1        tidyr_1.1.3       purrr_0.3.4       magrittr_2.0.1   
[41] usethis_2.0.1     codetools_0.2-18  ellipsis_0.3.2    assertthat_0.2.1  rvest_1.0.0      
[46] future_1.21.0     tinytex_0.31      utf8_1.2.1        stringi_1.5.3     cachem_1.0.4     
[51] crayon_1.4.1 
@saiemgilani
Copy link
Collaborator

I just put the fix in for v1.0.2, I should probably add some sort of local test for this. There is another issue i'm resolving to get the columns working. No need to open an issue, this will be resolved in a bit without requiring an update

@jedwards757
Copy link
Author

Awesome, thanks for the rapid fix!

@saiemgilani
Copy link
Collaborator

saiemgilani commented May 20, 2021

Please take a second to re-update the package to v1.0.3, otherwise it appears to be working now for nba data and will soon for mbb data.

@saiemgilani saiemgilani reopened this May 20, 2021
@jedwards757
Copy link
Author

Works great for me! Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants