Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armstjc/add retrosheet Release Candidate 2 #42

Merged
merged 8 commits into from Sep 5, 2022
Merged

Armstjc/add retrosheet Release Candidate 2 #42

merged 8 commits into from Sep 5, 2022

Conversation

armstjc
Copy link
Collaborator

@armstjc armstjc commented Sep 4, 2022

  • Adds Retrosheet data functionality to the sportsdataverse-py Python package.
  • Adds Retrosplits data functionality to the sportsdataverse-py Python package.
  • Cleaned up pre-existing code for MLBAM functions in sportsdataverse-py.
  • Updated docs to add references to the new, MLB-related functions.

@armstjc armstjc added the enhancement New feature or request label Sep 4, 2022
@vercel
Copy link

vercel bot commented Sep 4, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sportsdataverse-py ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 11:50PM (UTC)

akeaswaran
akeaswaran reviewed Sep 4, 2022
View reviewed changes
docs/docs/mlb/index.md Outdated Show resolved Hide resolved
akeaswaran
akeaswaran reviewed Sep 4, 2022
View reviewed changes
docs/docs/mlb/index.md Outdated Show resolved Hide resolved
akeaswaran
akeaswaran reviewed Sep 4, 2022
View reviewed changes
docs/docs/mlb/index.md Outdated Show resolved Hide resolved
akeaswaran
akeaswaran reviewed Sep 4, 2022
View reviewed changes
docs/docs/mlb/index.md Outdated Show resolved Hide resolved
akeaswaran
akeaswaran reviewed Sep 4, 2022
View reviewed changes
docs/docs/mlb/index.md Outdated Show resolved Hide resolved
@armstjc armstjc changed the title Armstjc/add retrosheet Release Candidate 1 Armstjc/add retrosheet Release Candidate 2 Sep 4, 2022
saiemgilani
saiemgilani approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@saiemgilani saiemgilani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@armstjc armstjc merged commit 69c996f into main Sep 5, 2022
@armstjc armstjc deleted the armstjc/add-retrosheet branch September 5, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiemgilani saiemgilani saiemgilani approved these changes

@akeaswaran akeaswaran Awaiting requested review from akeaswaran

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armstjc @akeaswaran @saiemgilani