array() of blocks() are readonly but PortableText requires a mutable value.

[miklschmidt]

Currently you have to go through some hoops to not get errors.

type DeepWriteable<T> = { -readonly [P in keyof T]: DeepWriteable<T[P]> };
return (
    <PortableText value={value as DeepWriteable<typeof value>} components={} />
)

Am i doing something wrong, or could we maybe use the readOnly prop in the schema to make these mutable in the resulting types?

[saiichihashimoto]

I don't remember where in the typing it is, but having this be readonly wasn't an intentional decision, but rather a consequence of convenience. It was just easier to produce a readonly value somewhere. If you can identify it with a fix, would be happy to accept a PR.

For clarity: returning a readonly type is different than the readOnly prop, nor should they be the same. The readOnly prop is so that the sanity UI doesn't allow editing. Returning a readonly type is about immutability in your codebase, which is entirely your own decision. Considering readOnly can be a function, it's very clear these refer to entirely different things.

[miklschmidt]

I realized that 5 minutes after i posted, still learning sanity, just jumped on it yesterday :)

i’ll see if i can come up with a fix :)

[miklschmidt]

Just to be sure, i’m just making the array/block types mutable, or do you want to drop readonly from everything? It sort of makes sense that they’re all readonly, you’re not supposed to mutate them, it just makes it harder to pass them to other code that (maybe incorrectly) don’t expect a readonly type.

[miklschmidt]

It's easy enough to just get rid of readonly alltogether, just remove readonly from TupleOfLength, and it's gone, everything checks out. But i'm not sure that's what you want, in which case it looks a lot more complicated, and it would prolly take me a while to figure out exactly how this thing is put together (thank you so much for doing that btw, ever since tRPC i have a hard time living without inferred end to end typesafety, lol).

[github-actions]

🎉 This issue has been resolved in version 1.15.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀