Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsqlite3.so.0 added into the list of allowed libraries #86

Merged
merged 1 commit into from Mar 6, 2017

Conversation

rinigus
Copy link
Contributor

@rinigus rinigus commented Jan 18, 2017

To my understanding, SQLite is used in several core parts of Sailfish. Its an important library in Linux and allows to expand functionality of applications in SFOS. In particular, it allows to use other libraries developed in Linux that use SQLite as a backend for their storage. In my case, adding sqlite3 into the list of allowed libraries allows me to incorporate a new geocoder into offline maps server application that I wrote for SFOS.

Copy link
Contributor

@jlehtoranta jlehtoranta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of sqlite3 is already allowed via the Qt API, but it makes sense to allow libsqlite3 as well. So, lgtm + targeting SFOS 2.1.1.

@jlehtoranta jlehtoranta merged commit c61ccb5 into sailfishos:master Mar 6, 2017
@rinigus
Copy link
Contributor Author

rinigus commented Mar 6, 2017

Thank you very much! Indeed, Qt API allows to use it, but its also needed for libs that use sqlite directly.

Since its my first commit, I think that I missed adding sqlite to allowed_requires.conf . Maybe there are more places as well... Should I submit additional PR or would you add sqlite yourself to allowed_requires?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants