Old Patchmanager 4 branch

[Olf0]

I always wondered what Andrey planned in detail for Patchmanager 4, looking at the pm4 branch:

• Structurally it contains a single big commit on top of Patchmanager 3 in February 2019.
  This is a bit unfortunate (technically no "cherry picking" possible, a little hard to review / analyse), but somewhat understandable, because ...
• Its changes seem to be basically clean-up work, which apparently were done locally in one go.

@CODeRUS, can you briefly describe what your intentions / goals were for PM4, i.e., what you wanted to achieve / change compared to PM3?
Do you think there may be specific changes, which are still worth being analysed and considered? Or do you advise to ignore that code / branch altogether?

[b100dian]

I got a few lines chatting with Andrey - basically asking the same question, what's the gist/idea behind this branch.
He said that the reason was he was planning a full rewrite, since the

current architecture is painful. based on old code based on old code. pathmanagerobject superclass is bad, hard to maintain

However these were only plans - it sounded to me like a first commit to make a "clean break" from the pm3 stuff.

While it sounds like a good plan to have something cleanly redone, it doesn't seem to me like an architectural change the magnitude pm2 vs pm3 is.

I think we can archive that branch for posterity:)

[Olf0]

Thank you for (obtaining the) information!