-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP saga floating window design #87
Comments
That looks like a bug to me, see the following issue for the expected rendering of LSP Saga's pop-ups: sainnhe/everforest#88 You closed the issue almost immediately after opening it, does it mean you found a solution? If yes, could you please share your findings? |
@antoineco My issue was completely different and i resolved it on my own. But i realised what i had shown does resemble that issue in the referenced issue on everforest. I was able to replicate that problem on sonokai. |
Strange, we fixed that in #67. Maybe something changed in LSP Saga since that fix. |
OK looks like there were indeed a couple of breaking changes introduced in LSP Saga, and there is now a single highlight group for all diagnostic borders: https://github.com/glepnir/lspsaga.nvim/blob/44af2ab1/lua/lspsaga/highlight.lua#L60 Ref. nvimdev/lspsaga.nvim#586 ( |
Will there be a fix made in this theme to support this change? |
Yes, and ported to all sainnhe's color schemes as soon as I test the potential fix locally. |
I just looked into this issue and things are a bit more granular than I though. By default, LSP Saga has the option For example, a Hint pop-up is created with a border which highlight group is linked to This is bad for two reasons:
Before, we could get away with setting Some plugins—like lualine for example—are graceful enough to allow the user to customize fallback groups. LSP Saga could adopt a similar approach and use We are most definitely not going to override internal highlight groups to accommodate one specific plugin, so unless the author of LSP Saga changes their approach to border rendering, LSP Saga won't be supported in Sonokai / Gruvbox material / Everforest / Edge moving forward. |
Okay i appreciate the effort looking into this. Maybe its something to bring up to the maintainer of LSPSaga. |
Cross referencing sainnhe/everforest#136 (same root cause) |
Hi using im using lsp saga and hovering over a function a floating window appears. I want to remove the padding on this floating window and change the background color of it.
Any idea how i might go about doing that by modifying this theme?
The text was updated successfully, but these errors were encountered: