Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions #34

Closed
blaryjp opened this issue Oct 20, 2021 · 1 comment
Closed

Some questions #34

blaryjp opened this issue Oct 20, 2021 · 1 comment

Comments

@blaryjp
Copy link

blaryjp commented Oct 20, 2021

Hello,

First of all, thank you for your awesome work, this is very inspiring .

  1. I wondering what is the purpose of the (empry) folder "providers" in "infrastructure"? I found nothing in the doc.
  2. Why do you rename "core" to "libs"? I loved the previous name, so I'ld like to know the reasons for this renaming.
  3. Why the file "infrastructure/interceptors/exception.interceptor.ts" is not in "libs" folder, as it seems generic?

Thank you very much :)!

@Sairyss
Copy link
Owner

Sairyss commented Oct 20, 2021

Hey,

  1. Its for the custom shared providers (there is none in the project at the moment) https://docs.nestjs.com/providers
  2. its not a rename since libs now contains not only core files, but also infrastructure, interface adapters, exceptions etc. I called it libs because those are basically generic libraries that are shared between multiple microservices
  3. it depends on how you look at it. At the project I am currently working on similar interceptor is only needed in the API gateway that handles HTTP calls and communicates to microservices that don't know anything about HTTP exceptions, so there is no need for this interceptor anywhere else. If in your project you need to share it I would put it inside libs yes

@Sairyss Sairyss closed this as completed Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants