Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leaks detected in image_buffer_resize at fromsixel.c:293 #117

Closed
SuhwanSong opened this issue Dec 16, 2019 · 3 comments
Closed

memory leaks detected in image_buffer_resize at fromsixel.c:293 #117

SuhwanSong opened this issue Dec 16, 2019 · 3 comments

Comments

@SuhwanSong
Copy link

img2sixel 1.8.3

There is a memory leak in image_buffer_resize at fromsixel.c:293
please run following cmd to reproduce it.

img2sixel $PoC

poc
ASAN LOG

==17978==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 67108864 byte(s) in 1 object(s) allocated from:
    #0 0x4da230 in __interceptor_malloc (/home/tmp/img2sixel+0x4da230)
    #1 0x7f87fcbbabd1 in image_buffer_resize /home/tmp/libsixel/src/fromsixel.c:293:35

SUMMARY: AddressSanitizer: 67108864 byte(s) leaked in 1 allocation(s).
@saitoha
Copy link
Owner

saitoha commented Dec 17, 2019

This problem is caused by huge repeat count parameter in SIXELs. It seems to be fixed in v1.8.3, with 9c013f2. Thanks!

@saitoha saitoha closed this as completed Dec 17, 2019
@saitoha saitoha reopened this Dec 20, 2019
@saitoha
Copy link
Owner

saitoha commented Dec 20, 2019

I misrecognized. It still occurs in v1.8.4.

@saitoha saitoha mentioned this issue Dec 20, 2019
Closed
@saitoha
Copy link
Owner

saitoha commented Jan 3, 2020

Fixed on v1.8.5. Thanks!

@saitoha saitoha closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saitoha @SuhwanSong