Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'dot arcade' to home page. #190

Closed
arpee opened this issue Aug 5, 2021 · 4 comments · Fixed by #191
Closed

Add 'dot arcade' to home page. #190

arpee opened this issue Aug 5, 2021 · 4 comments · Fixed by #191
Assignees

Comments

@arpee
Copy link
Member

arpee commented Aug 5, 2021

Add a 'dot arcade' section and link to the home page.

  • Add section at place 3 (between sectionWrapper2 and sectionWrapper3 (does not need to follow this naming convention).

  • Add content from saito.io/dotacrade to this section.

  • Change 'Play Poker' to 'Play Games'

  • Make sure it's still nice and responsive

  • Add anchor #dotarcade above section

  • add top menu link to saito.io/#dotarcade between 'Get Saito Tokens' and '中文'

@arpee arpee created this issue from a note in 单薄 and Ramses! (Todo) Aug 5, 2021
@arpee
Copy link
Member Author

arpee commented Aug 9, 2021

For now we want this to be 'Dot Arcade' promoting the colaboration - rather than just 'arcade'. So can the header linke be updated and the same image used (for now) as the /dotarcade page.

I am also seeing issues when the page/view aspect is very tall...

Seems like: min-height: 80vh; in the definition at line 388 is unnecessary - thought I don't know what negatives side effects
occur if it's removed. Can you check?

Thanks.

@arpee arpee moved this from Todo to Done in 单薄 and Ramses! Aug 18, 2021
@arpee arpee moved this from Done to Todo in 单薄 and Ramses! Aug 18, 2021
@f8daniel f8daniel moved this from Todo to Doing in 单薄 and Ramses! Aug 24, 2021
@f8daniel f8daniel self-assigned this Aug 24, 2021
@f8daniel
Copy link
Member

OMG, I never saw this comment until today.
Fixed the issues raised here and in the (now updated) pull request, i.e. keeping the branding more consistent and not littering the css with unnecessary commands/commented out commands.

I wasn't able to replicate any issues with the responsive layout on monster screen sizes (stretched out to 1000s of pixels either way), so should be good to merge back into the master branch and prune this fcking timeline.

For now we want this to be 'Dot Arcade' promoting the colaboration - rather than just 'arcade'. So can the header linke be updated and the same image used (for now) as the /dotarcade page.

I am also seeing issues when the page/view aspect is very tall...

Seems like: min-height: 80vh; in the definition at line 388 is unnecessary - thought I don't know what negatives side effects
occur if it's removed. Can you check?

Thanks.

@arpee
Copy link
Member Author

arpee commented Sep 2, 2021

Commented in the Pull request - the idea is to have the Play button in the dotarcade section on the home page trigger the same functionality as clicking the play button at /dotarcade.

@f8daniel f8daniel moved this from Doing to Ready (Pull Requested) in 单薄 and Ramses! Sep 2, 2021
@arpee
Copy link
Member Author

arpee commented Sep 3, 2021

All good in my testing. Triggers the popup and hits the endpoints just fine.

Thanks. Will pull.

@arpee arpee closed this as completed in #191 Sep 3, 2021
@f8daniel f8daniel moved this from Ready (Pull Requested) to Done in 单薄 and Ramses! Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants