Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy error: src/blockchain.rs:315:16 - this boolean expression contains a logic bug #217

Closed
escapedcat opened this issue Aug 31, 2021 · 0 comments
Labels
clippy https://github.com/rust-lang/rust-clippy

Comments

@escapedcat
Copy link
Contributor

escapedcat commented Aug 31, 2021

https://github.com/SaitoTech/saito-rust/runs/3468793166#step:3:1076

error: this boolean expression contains a logic bug
   --> src/blockchain.rs:315:16
    |
315 |             if save_to_disk || true {
    |                ^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true`
    |
    = note: `#[deny(clippy::logic_bug)]` on by default
help: this expression can be optimized out by applying boolean operations to the outer expression
   --> src/blockchain.rs:315:16
    |
315 |             if save_to_disk || true {
    |                ^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
@escapedcat escapedcat added the clippy https://github.com/rust-lang/rust-clippy label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clippy https://github.com/rust-lang/rust-clippy
Projects
None yet
Development

No branches or pull requests

1 participant