Compatibility with Windows

[TomDeneire]

Docconv seems to give trouble when running on Windows computer. In doc.go for instance there is a hardcoded path to a tempdir which includes a forward slash (line 17 and 60 e.g.). This is definitely a problem for a Windows OS...

[mish15]

@TomDeneire interesting. Haven't used windows in over 10 years. Happy to take a PR if you want to fix it?

[TomDeneire]

I only found out when doing a build for Windows myself. The OS separator issue has been my nemesis before ;-) I'm only a novice programmer though, so I'm not really sure if I can accurately fix it, throughout the code. But I may give it a try if I find the time (I'm only using docconv in a pet project). I'll keep you posted!

[mish15]

Yeah we don't have anyone on windows, so tough to work out a solution. I expect it can be done easily with build tags if you can tell us what is needed in windows at each line in our code?

[TomDeneire]

I know, I can't regularly test on Windows myself, so hard to see what's happening. I've tried to replace all instances of hardcoded "/" by using something like var := string(os.PathSeparator), which is a start, but does not seem to do the trick just yet.

[al-sabr]

Any update on that ?

[mish15]

@TomDeneire can you try this branch please: https://github.com/sajari/docconv/tree/windows-separator

[mish15]

@TomDeneire @gdeverlant can either of you test this branch on windows?

[al-sabr]

I would like to but how do we deal with the dependencies?

tidy, wv, popplerutils, unrtf, https://github.com/JalfResi/justext ?

How about you use VirtualBox for testing or show us how to deal with the dependencies on Windows?

[TomDeneire]

Sorry guys, I won't have access to a suitable Windows machine for the next few days. Will try next week.

[mish15]

@gdeverlant dependencies may be tough also! I would probably avoid windows if possible or run in a container using the docker images.

[al-sabr]

I found theses all for Windows on their respective web sites but I don't know how to map them with this project :

poppler.zip
tidy-5.6.0-vc14-32b.zip
tidy-5.6.0-vc14-64b.zip
unpaper-6.2-x64.zip
unrtf-0.19.3-bin.zip
wv-1.0.2-bin.zip

[al-sabr]

Any update for this =

[mish15]

@gdeverlant none of us have windows. As per above we’re happy to take a PR

[al-sabr]

Lol you mean you don't have Virtual Box with a windows image ?

Common !!!! let me help you :D https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

I was kind enough to find all the dependencies but I don't get it how to map it with golang.

[dhowden]

@gdeverlant The way for you to run this in Windows is to use Docker.

I have just created a Docker image (i.e. similar to docd/debian.sh in the repo) for you and pushed it to DockerHub. Assuming you have Docker on windows setup:

$ docker pull dhowden/docconv-debian:1.1.0

[dhowden]

Closing this as resolved for now, feel free to re-open if you have issues running the Docker container.