Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SVGs #31

Closed
kmnaseef opened this issue Jun 19, 2023 · 5 comments
Closed

Support for SVGs #31

kmnaseef opened this issue Jun 19, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@kmnaseef
Copy link

kmnaseef commented Jun 19, 2023

Adding below lines, .gif and .svg files can be opened with coil AsyncImage.

imageLoader = ImageLoader.Builder(context)
    .components {
        add(SvgDecoder.Factory())  // svg
        add(ImageDecoderDecoder.Factory()) // gif
    }
    .build()

but with ZoomableAsyncImage, gif files can be played without any problem, but svg files not open.

@saket saket added the bug Something isn't working label Jul 12, 2023
@saket
Copy link
Owner

saket commented Jul 13, 2023

I haven't investigated this yet, but I think my decision to enable sub-sampling for all bitmaps may be causing this. Let me fix this.

@kmnaseef
Copy link
Author

Ok. Thanks...

@saket
Copy link
Owner

saket commented Jul 18, 2023

Fixed in e1ad337.

@saket saket closed this as completed Jul 18, 2023
@saket
Copy link
Owner

saket commented Jul 18, 2023

Thanks for reporting this @kmnaseef! I'll release the fix as part of 0.5.0 soon. In the meantime, you can unblock yourself by using 0.5.0-SNAPSHOT.

@kmnaseef
Copy link
Author

You're welcome bro..

@saket saket changed the title Open SVG file Support for SVGs Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants