Fix #9. Emit 'open' event in createReadStream and createWriteStream. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I just pushed updated .travis.yml file, so it would be great if you could do a rebase please. |
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "fs-mock", | |||
| "description": "Simple fs mock with posix and windows file system styles", | |||
| "version": "1.1.2", | |||
| "version": "1.1.3", | |||
There was a problem hiding this comment.
Please, can I ask you to revert that change? I'll do that later myself
|
I've made the requested changes. |
|
Just one last thing, can I ask you to squash all commits please? |
This fixes a bug where the 'open' event was not emitted from createReadStream and createWriteStream when they were opened.
|
Done |
davidkudera
added a commit
that referenced
this pull request
Feb 5, 2015
Fix #9. Emit 'open' event in createReadStream and createWriteStream.
|
Thanks again |
|
Any ETA on when the new version might be published? |
|
At first I wanted to wait for response to #8, but I'll probably release new version right now. |
|
done |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the 'open' event was not emitted from createReadStream and createWriteStream when they were opened.