Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative Serving CloudEvents Controller Proposal #1

Open
salaboy opened this issue Sep 28, 2021 · 0 comments
Open

Knative Serving CloudEvents Controller Proposal #1

salaboy opened this issue Sep 28, 2021 · 0 comments

Comments

@salaboy
Copy link
Owner

salaboy commented Sep 28, 2021

The main objective of this controller for Knative Serving is to externalize the state of the Knative Service resources so other tools can react to these events. One of the main objectives of this controller is to enable interoperability with other tools outside the Knative ecosystem, hence this proposal relies on the http://cd.foundation sig-events working group definitions for events. This is achieved by using the CDE library to emit events defined in this common and shared vocabulary.

Goals

If this controller is present on a Knative Serving installation, this controller should:

  • Watch Knative Service resources and emit CD events (CDE) for the following scenarios
    • A new service is registered
    • A service change its state from not ready to ready
    • A service point to a new revision
    • A service is deleted
    • A service is scaled down or scaled up
  • This controller shouldn't have any dependency on Knative Eventing

This controller should follow the same approach as the Tekton cloud events controller:
https://github.com/tektoncd/experimental/tree/main/cloudevents

This controller doesn't define any new CRD

This controller needs to use events defined here: https://github.com/tektoncd/experimental/blob/main/cloudevents/go.mod#L6

If there is an event that we need to emit that is currently not defined we need to submit a PR to:
https://github.com/cdfoundation/sig-events/tree/main/cde/sdk/go

After milestone 1 we need to create a proposal to add this project to the knative-sandbox org and advertise for other developers to help us improve the code.

@salaboy salaboy changed the title Controller Requirements Knative Serving CloudEvents Controller Proposal Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant