Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Object handling to better map to reality #12

Closed
4 tasks done
SaladDais opened this issue May 29, 2021 · 1 comment
Closed
4 tasks done

Rework Object handling to better map to reality #12

SaladDais opened this issue May 29, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@SaladDais
Copy link
Owner

SaladDais commented May 29, 2021

Right now objects are handled at the region level, which breaks handling of sim->sim object crossings. The proxy also assumes that whatever region the objectupdate was received from is the owner of the object it's updating, which isn't correct. indra only goes off of the RegionHandle in the body of each ObjectUpdate type, and that's what triggers object handoff. Getting an Object's global pos isn't possible either because they don't know what region they belong to.

Need to:

  • Store region handle on objects so they know what region they belong to and can calculate their global position
  • Switch to doing internal lookups by FullID. LocalID + Handle is only ever used to lookup the FullID in indra. Any update could potentially change an object's localid
  • Move ObjectManager to Session. That model works better for region handoff. Keep something simple on the region so lookups by localid can still be done?
  • Handle region handoff correctly and add tests
@SaladDais SaladDais added the enhancement New feature or request label May 29, 2021
@SaladDais SaladDais self-assigned this May 29, 2021
@SaladDais
Copy link
Owner Author

Fixed by ebc02f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant